From: Giovanni Campagna <gcampagna@src.gnome.org>
Date: Sat, 8 Sep 2012 16:54:50 +0000 (+0200)
Subject: MessageTray: fix unexpanded height when receiving multiple telepathy messages
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5896
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=9f48adcff9692ef6ac70df2e806d72841ded3b8c;p=gnome-shell.git

MessageTray: fix unexpanded height when receiving multiple telepathy messages

ClutterBinLayout is so amazingly broken: it uses the y_expand property to
find out if the children needs to honor alignment/fill, but that property is
"bubbled up" from the grand-children, so the notificationWidget would notice
the y_expand on the notificationBin (necessary to make the layout manager on
notificationWidget honor the alignment property for the bin), and would
receive the full height of the MessageTray actor from the parent's layout manager,
resulting in a notificationWidget shifting up, with the notification detached
from the screen.

https://bugzilla.gnome.org/show_bug.cgi?id=683628
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 614842e51..481161a17 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1379,7 +1379,9 @@ const MessageTray = new Lang.Class({
         this.actor.connect('notify::hover', Lang.bind(this, this._onTrayHoverChanged));
 
         this._notificationWidget = new St.Widget({ name: 'notification-container',
+                                                   y_align: Clutter.ActorAlign.START,
                                                    x_align: Clutter.ActorAlign.CENTER,
+                                                   y_expand: true,
                                                    x_expand: true,
                                                    layout_manager: new Clutter.BinLayout() });
         this.actor.add_actor(this._notificationWidget);